Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of volatile keyword #24318

Closed
kouvel opened this issue May 20, 2021 · 3 comments · Fixed by #26041
Closed

Improve documentation of volatile keyword #24318

kouvel opened this issue May 20, 2021 · 3 comments · Fixed by #26041

Comments

@kouvel
Copy link
Member

kouvel commented May 20, 2021

Improve documentation of volatile keyword in docs/csharp/language-reference/keywords/volatile.md to clarify what it does and fix some inaccurate info.

-edit by @BillWagner to add document block.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@IEvangelist
Copy link
Member

Hi @BillWagner - should this have been closed from #24315?

@kouvel
Copy link
Member Author

kouvel commented May 27, 2021

While reviewing that PR I found a few more things that should be fixed so this issue is tracking that

@GrabYourPitchforks
Copy link
Member

Thanks @kouvel for picking this up! I'm glad to see even more eyes on this. :)

kouvel added a commit to kouvel/dotnet-api-docs that referenced this issue Sep 10, 2021
- Clarify terms used in `LazyThreadSafetyMode` field names. Relevant to dotnet/docs#12214.
- Clarify documentation of the `Volatile` class. Relevant to dotnet/docs#24318.
- Update docs for `Thread.VolatileRead` and `Thread.VolatileWrite`. Fixes dotnet#2518.
- Clarify something about `ManualResetEventSlim`'s perf benefit over `ManualResetEvent`. Fixes dotnet#3323.
kouvel added a commit to kouvel/docs that referenced this issue Sep 10, 2021
- Document new settings available to configure the rate of thread injection for sync-over-async. Fixes dotnet#24566.
- Clarify documentation of the `volatile` keyword. Fixes dotnet#24318.
- Add link to clarify some terms in `LazyThreadSafetyMode` field names. Fixes dotnet#12214.
carlossanlop pushed a commit to dotnet/dotnet-api-docs that referenced this issue Sep 13, 2021
* Clarify/fix some threading API docs

- Clarify terms used in `LazyThreadSafetyMode` field names. Relevant to dotnet/docs#12214.
- Clarify documentation of the `Volatile` class. Relevant to dotnet/docs#24318.
- Update docs for `Thread.VolatileRead` and `Thread.VolatileWrite`. Fixes #2518.
- Clarify something about `ManualResetEventSlim`'s perf benefit over `ManualResetEvent`. Fixes #3323.

* Apply suggestions from code review

Thank you!

Co-authored-by: Genevieve Warren <[email protected]>

Co-authored-by: Genevieve Warren <[email protected]>
kouvel added a commit that referenced this issue Sep 13, 2021
* Clarify/fix some threading docs

- Document new settings available to configure the rate of thread injection for sync-over-async. Fixes #24566.
- Clarify documentation of the `volatile` keyword. Fixes #24318.
- Add link to clarify some terms in `LazyThreadSafetyMode` field names. Fixes #12214.

Co-authored-by: Genevieve Warren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants