Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: anchor sometimes failed to scroll #9251

Merged
merged 3 commits into from
Sep 28, 2023
Merged

fix: anchor sometimes failed to scroll #9251

merged 3 commits into from
Sep 28, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Sep 27, 2023

This seems to reliably force scroll to the right position.

fixes #9150

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@yufeih yufeih merged commit ba9d340 into main Sep 28, 2023
@yufeih yufeih deleted the fix-anchor branch September 28, 2023 05:12
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
* fix: anchor sometimes failed to scroll

* fix lint

* fix test

---------

Co-authored-by: Yufei Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Randomly failed to scroll to anchor when opening docfx site's anchor link
1 participant