separate default template for easy customization #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hellosnow
reviewed
Oct 24, 2016
| // Copyright (c) Microsoft. All rights reserved. Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
|
|
||
| exports.preSteps = function (model) { | ||
| return model; |
There was a problem hiding this comment.
question, how about process model directly and not return model itself? #Pending
There was a problem hiding this comment.
As discussed, remain this as user may want to return a new model.
In reply to: 84629091 [](ancestors = 84629091)
vwxyzh
approved these changes
Oct 24, 2016
| @@ -2,8 +2,13 @@ | |||
|
|
|||
| var mrefCommon = require('./ManagedReference.common.js'); | |||
There was a problem hiding this comment.
what about require('./ManageReference.extension.js');? #Resolved
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#662
provide 2 functions for each type: preSteps() and postSteps, which defined in type.html.primary.extension.js. Users can change this file to modify the model.
@chenkennt @vwxyzh @hellosnow @ansyral @qinezh