-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update xUnit related package version to v3 #10474
Draft
filzrev
wants to merge
11
commits into
dotnet:main
Choose a base branch
from
filzrev:chore-update-xunit-to-v3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
115da34
to
29128a9
Compare
36241e0
to
ff545e2
Compare
2626bc2
to
7b78733
Compare
* deps: update dependencies * chore: fix ci error of plantuml test
* docs: fix nightly build install steps * chore: fix ci error of plantuml test
* chore: modify regex settings * chore: fix ci error of plantuml test
chore: fix ci error of plantuml test
…#10546) Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.2.1 to 3.2.4. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@3.2.1...3.2.4) --- updated-dependencies: - dependency-name: dompurify dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…with 2 updates (dotnet#10547) Bumps the typescript-eslint group with 2 updates in the /templates directory: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) and [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser). Updates `@typescript-eslint/eslint-plugin` from 8.24.0 to 8.24.1 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.24.1/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 8.24.0 to 8.24.1 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.24.1/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: typescript-eslint - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: typescript-eslint ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…mpilations (dotnet#10491) * Use provided references for search for dependencies in AssemblyCompilation + small code duplication cleanup * Added code to warning * Fixes whitespace --------- Co-authored-by: Yufei Huang <[email protected]>
1d92161
to
313a6bb
Compare
313a6bb
to
f0500b4
Compare
[skip ci]
f0500b4
to
6dc0d98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is Draft PR to migrate unit test projects to
xUnit v3
. (Prev draft PR is #10375)Currently test execution on VS is unstable
Known issues
TestTfmsInParallel: false
setting is not works as expected when running tests with VS Test Explorer(
https://github.com/xunit/visualstudio.xunit/issues/429
)What's changed to this PR
1. Switch xUnit.NET related NuGet packages to v3.
Verify.Xunit
->Verify.XunitV3
xunit
->xunit.v3
2. Add additional output log types (
*.log
/*.ctrf
)3. Change unittest's projects
OutputType from
Libraryto
Exeand Exolicitly set
IsTestProject` property4. Add
Microsoft.Testing.Platform
related settingsMicrosoft.Testing.Platform is alternative unit test execution layers.
6. Add
xunit.runner.json
config file for test project.7. Pass
TestContext.Current.CancellationToken
that require Cancellation token.8. Modify
MetadataCommandTest.cs
And add steps to create dummyDirectory.Build.props
file.It's required to ignore project directories
Directory.Build.props
settings9. Add empty
Directory.Build.props
file to samples directory10. Modify CI workflow to use custom
seed
value to reproduce issue on CIBy default. xUnit determine
seed
on build time and seed value is different between assemblies.So to fix seed value. Use
github.run_number
as a seed value. (It's incremented from 1)If CI failed by parallel execution related issue.
It can re-run job with using same seed.
11. Add
SetBranchNameAttribute
that derived fromBeforeAfterTestAttribute
When running
SeedMarkdown
tests before other snapshot tests.It cause snapshot diffs because
GitUtility.cs
caching actual branch name.To simplify environment variable set/restore.
Add custom
BeforeAfterTestAttribute
for this purpose.12. Add
[assembly:CaptureConsole]
attribute to test assemblies.13. Add ProcessHelper class to invoke external command (e.g. dotnet, docfx).
When using
Process.Start
to launch external command that stdout.Running tests is not completed when running tests on Test Explorer.
So I've added utility code to ignoring stdout/stdout.
15. Modify
dotnet test --filter Stage=Percy
command. to use-- --filter-trait "Stage=Percy"
When
TestingPlatformDotnetTestSupport
is enabled.dotnet test
command's--filter
argument is silently ignored. (Same behavior as that reported athttps://github.com/microsoft/testfx/issues/4401
)It need modify command to pass additional argument(
-- --filter-trait "Stage=Percy"
)16. Separate
Chromium Headless Shell
installation from test stepsChromium is installed on when running
docfx pdf
command first time.It take times and it affects test execution times.
So creating separate chromium install step that is executed before running
dotnet test
.https://github.com/dotnet/docfx/pull/10474/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR43-R48
17. Add
-nodereuse:false
and--no-dependencies
parameter todotnet build
command inside testsAfter migrated to xUnit v3.
SamplesTest::Extensions
dotnet build
command takes extra 15 minutes on Windows CI.It seems relating to
https://github.com/dotnet/sdk/issues/9452
so I've added-nodereuse:false
parameter to resolve issue.And adding
--no-dependencies
parameter to suppressDocfx.App
project build during test.**18. Add
dotnet-coverage
command related settings.Currently Microsoft.Testing.Platform don't support coveret-based codecoverage with
dotnet test
command.