Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Dockerfile #10407

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Nov 20, 2024

This PR update Dockerfile

What's changed

  1. Update base OS image version.
  2. Update docfx version to 2.78.1
  3. Remove apt-get update command. And use apt-get install with --update option instead (that is added on Ubuntu 24)
  4. Change library dependencies installation to use --with-deps options.
  5. Remove temporary symbolic link steps. (Currently .playwright directory is placed under bin)

Test
I've confirmed docker image successfully build.
And docfx pdf command is works as expected with following steps.

docker build ./ -t docfx

docker run -it --rm --entrypoint /bin/bash docfx
docfx init --yes
docfx build
docfx pdf

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @filzrev

@yufeih yufeih merged commit c6c87a3 into dotnet:main Nov 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants