Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report missing DAC error for cross DAC clrstack -i #973

Merged
2 commits merged into from
Apr 2, 2020
Merged

Report missing DAC error for cross DAC clrstack -i #973

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49ce814
Report missing DAC error for cross DAC clrstack -i
sdmaclea Apr 1, 2020
c501afa
Feedback
sdmaclea Apr 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/SOS/Strike/strike.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13311,7 +13311,11 @@ class ClrStackImplWithICorDebug
HRESULT Status;

ICorDebugProcess* pCorDebugProcess;
IfFailRet(g_pRuntime->GetCorDebugInterface(&pCorDebugProcess));
if (FAILED(Status = g_pRuntime->GetCorDebugInterface(&pCorDebugProcess)))
{
ExtOut("\n\n\n!clrstack -i is unsupported on this target.\nThe ICorDebug interface cannot be constructed.\n");
sdmaclea marked this conversation as resolved.
Show resolved Hide resolved
return Status;
}

ExtOut("\n\n\nDumping managed stack and managed variables using ICorDebug.\n");
ExtOut("=============================================================================\n");
Expand Down