Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ps handler for elevated process #749

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Fix ps handler for elevated process #749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Tools/Common/Commands/ProcessStatus.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ public static void PrintProcessStatus(IConsole console)
{
sb.Append($"{process.Id, 10} {process.ProcessName, -10} [Elevated process - cannot determine path]\n");
}
catch (NullReferenceException)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we getting a NullReferenceException here in the first place? The docs seem to indicate that we should get the InvalidOperationException if we are unable to get ProcessName. Are we running up against something else? If we aren't and this is indeed an expected result, should we mirror this exception below as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting it because process.MainModule is null, not ProcessName.

{
sb.Append($"{process.Id, 10} {process.ProcessName, -10} [Elevated process - cannot determine path]\n");
}
}
console.Out.WriteLine(sb.ToString());
}
Expand Down