Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview Features #192

Merged
merged 6 commits into from
Apr 23, 2021
Merged

Preview Features #192

merged 6 commits into from
Apr 23, 2021

Conversation

terrajobst
Copy link
Contributor

No description provided.

@terrajobst terrajobst mentioned this pull request Mar 22, 2021
Closed
@terrajobst terrajobst changed the title Add spec for preview features Preview Features Mar 22, 2021
@stephentoub
Copy link
Member

stephentoub commented Mar 29, 2021 •
edited
Loading

Hence seems odd to have <LangVersion>preview</LangVersion> as the way to opt into that. I don't have a strong objection to using LangVersion but that is one oddity that comes to mind.

From my perspective, I think we do ourselves a disservice when we try to draw some kind of distinction between C# and the APIs that are usable from C#.

@333fred 333fred mentioned this pull request Apr 6, 2021
Closed
@terrajobst terrajobst force-pushed the preview-features branch 4 times, most recently from e27acb7 to 1cb1f1a Compare April 13, 2021 17:05
@terrajobst terrajobst merged commit 3c2168b into dotnet:main Apr 23, 2021
@terrajobst terrajobst deleted the preview-features branch April 23, 2021 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkotas jkotas jkotas left review comments

@jasonmalinowski jasonmalinowski jasonmalinowski left review comments

@marek-safar marek-safar marek-safar left review comments

@jonsequitur jonsequitur jonsequitur left review comments

@stephentoub stephentoub stephentoub left review comments

@danmoseley danmoseley danmoseley left review comments

@jaredpar jaredpar jaredpar left review comments

@jnm2 jnm2 jnm2 left review comments

@jcouv jcouv jcouv left review comments

@YairHalberstadt YairHalberstadt YairHalberstadt left review comments

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT left review comments

@mangod9 mangod9 mangod9 left review comments

@jmarolf jmarolf jmarolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Compiler: Julien's umbrellas
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.