Add detailed design to clarify the field keyword spec and incorporate all LDM decisions #8069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnm2
force-pushed
the
semiauto_spec_clarification
branch
from
c97468e to
8a49b97
Compare
jnm2
commented
Apr 23, 2024
RikkiGibson
reviewed
Apr 23, 2024
RikkiGibson
reviewed
Apr 23, 2024
jaredpar
reviewed
Apr 23, 2024
|
I also want to call out that this proposal does not include indexers. |
jnm2
commented
Apr 25, 2024
jnm2
force-pushed
the
semiauto_spec_clarification
branch
from
aa163ad to
e507eb4
Compare
|
@CyrusNajmabadi Are you still thinking we could need to take to LDM for some confirmations before merging? I think this is ready for that if so (could you look it over with the new updates)? |
RikkiGibson
reviewed
Jun 11, 2024
cston
reviewed
Jun 11, 2024
cston
reviewed
Jun 11, 2024
cston
reviewed
Jun 11, 2024
cston
reviewed
Jun 11, 2024
cston
approved these changes
Jun 12, 2024
cston
reviewed
Jun 21, 2024
cston
approved these changes
Jun 23, 2024
jaredpar
reviewed
Jun 24, 2024
| set | ||
| { | ||
| if (value == parent.AmbientValue) | ||
| field = null; // No warning here. Resume following the parent's value. |
There was a problem hiding this comment.
This feels wrong to me. Feel like this should be a warning and users complaining about that warning would be evidence that we should expand the feature in the future to allow explicit declaration of the field type.
There was a problem hiding this comment.
Great consideration, being discussed in WG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by noticing missing scenarios on SharpLab for the feature branch.
@CyrusNajmabadi indicated that this may need to go through LDM.