limit disposable pattern #6785
Merged
limit disposable pattern #6785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proposal spec'ed this out in general terms for any type, and included a provision to allow extension `Dispose` methods. The implementation only allows `ref` struct types to use the pattern-based Dispose. Furthermore, the `Dispose` method can't be an extension method. Fixes dotnet/docs#31815 I made edits to make the proposal match the implementation. As an alternative, I could make edits to indicate which portions of the proposal were implemented and which may be delivered in the future.
jcouv
reviewed
Dec 8, 2022
| statements. | ||
| - Extension methods will allow developers to augment types in other assemblies to participate |
There was a problem hiding this comment.
I confirmed from the code (TryFindDisposePatternMethod) that extension methods don't count. Tagging @chsienki to confirm this was intentional and to fix the speclet.
There was a problem hiding this comment.
Yes, extension methods we're explicitly disallowed, even for ref structs. The decision being that it would have been legal to have an extension method called 'Dispose' that previously wouldn't have been called if you used the type in a foreach. With the extension method lookup, it would now get called, which was considered too big a breaking change.
jcouv
approved these changes
Dec 8, 2022
chsienki
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposal spec'ed this out in general terms for any type, and included a provision to allow extension
Disposemethods.The implementation only allows
refstruct types to use the pattern-based Dispose. Furthermore, theDisposemethod can't be an extension method.Fixes dotnet/docs#31815
I made edits to make the proposal match the implementation. As an alternative, I could make edits to indicate which portions of the proposal were implemented and which may be delivered in the future. Let me know which you'd prefer.