Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

Deleted more ProjectN leftovers #8190

Merged
merged 1 commit into from
Jun 7, 2020

Conversation

FabianNitsche
Copy link
Contributor

While trying to build on RaspberryPi 3 B+ with Ubuntu 20.04 Arm64 I found some issues.

The compiler gave me the following error:

/home/ubuntu/projects/corert/src/Native/Runtime/MiscHelpers.cpp:354:42: error: member access into incomplete type 'Module'
        ASSERT(pModule == NULL || pModule->ContainsDataAddress(pIatCell));
                                         ^
/home/ubuntu/projects/corert/src/Native/Runtime/Portable/../forward_declarations.h:23:10: note: forward declaration of 'Module'
FWD_DECL(Module)
         ^
1 error generated.

It seems to be more leftovers from the ProjectN. And since Module is always null, I was so bolt to just delete the asserts, since they will always succeed.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MichalStrehovsky MichalStrehovsky merged commit 343a4ac into dotnet:master Jun 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants