This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Delete ProjectN leftovers from the native runtime #8049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also deleting module.cpp and RHCodeMan.cpp.
We'll probably want to do this from managed code.
jkotas
reviewed
Mar 21, 2020
jkotas
approved these changes
Mar 21, 2020
This will look a bit different.
Sorry for taking away the deletion fun from you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is more but this is the equivalent of pulling on a loose thread on a shirt and being left with no shirt.
I put the generic unification deletion in a separate commit in case we actually want to keep it. The rest shouldn't be needed anymore now that we have no plans to resurrect rhbind.exe.