Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

[Unix ThreadPool] Ported Hill Climbing from CoreCLR to CoreRT #3794

Merged
merged 13 commits into from
Jun 8, 2017
Merged

[Unix ThreadPool] Ported Hill Climbing from CoreCLR to CoreRT #3794

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f715396
Ported Hill Climbing from CoreCLR to CoreRT.
Jun 5, 2017
8e813e5
Fixed compile error and added license header.
Jun 5, 2017
dfca925
New unix-specific files now compile on Unix only. Removed unused memb…
Jun 5, 2017
4506c02
Make ClrThreadPool and hill climbing compile on both Windows and Unix…
Jun 6, 2017
3b9c90c
Move CLR threadpool classes to compile on Unix only for now.
Jun 6, 2017
ca78d25
Alphabetically sort project entries.
Jun 6, 2017
2f8e2fb
Add more TODO comments to ensure that SetMinThreads and SetMaxThreads…
Jun 6, 2017
9e19d33
Moved HillCimbing instance to be a static member on HillClimbing inst…
Jun 6, 2017
0aad3b8
Made changes consistent with PR feedback
Jun 6, 2017
2e5dc38
Fixed algorithm logic error
Jun 6, 2017
53e330f
More PR feedback
Jun 6, 2017
6cd9aa0
PR feedback on complex and file headers.
Jun 8, 2017
180c21a
Added comment referencing @mattwarren's article on the algorithm.
Jun 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/System.Private.CoreLib/src/System.Private.CoreLib.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,8 @@
<Compile Include="System\Resources\ResourceSet.cs" />
<Compile Include="System\Runtime\InteropServices\CriticalHandle.cs" />
<Compile Include="System\Text\CodePageDataItem.cs" />
<Compile Include="System\Threading\ClrThreadPool.Unix.cs" />
<Compile Include="System\Threading\ClrThreadPool.HillClimbing.Unix.cs" />
Copy link
Member

@jkotas jkotas Jun 5, 2017 •
edited by kouvel
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything Unix-specific in the file? Maybe call it just ClrThreadPool.HillClimbing.cs ? #Closed

Copy link
Member Author

@jkoritzinsky jkoritzinsky Jun 5, 2017 •
edited by kouvel
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this PR there isn't anything Unix-specific; however, in future PRs the rest of the thread pool implementation will have Unix-specific portions. The CPU utilization calculation specifically is the Unix-specific code that Hill climbing will touch.

I can change it if you would like me to do so.
#Closed

Copy link
Contributor

@sergiy-k sergiy-k Jun 6, 2017 •
edited by kouvel
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I would like to see the code structured in such a way that would be easy to enable ClrThreadPool on Windows too if it is needed (for example, for experiential/perf comparison purposes). #Closed

Copy link
Member Author

@jkoritzinsky jkoritzinsky Jun 6, 2017 •
edited by kouvel
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved the code to be available on both Windows and Unix. #Closed

Copy link
Member

@jkotas jkotas Jun 6, 2017 •
edited by kouvel
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want the code to be structured such that it is possible to enable it on Windows. You have done a step towards that by renaming the files from *.Unix.cs to *.cs.

But we do not want to be compiling the code in by default on Windows, at least for now. Could you please add Condition="'$(TargetsWindows)'!='true' on the new files in the .csproj file? #Closed

<Compile Include="System\__Canon.cs" />
<Compile Include="System\AccessViolationException.cs" />
<Compile Include="System\Activator.cs" />
Expand Down
Loading