This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Revert "OSX unwind workaround" #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@christianscheuer When you get a chance, could you please check whether your project works now even with this workaround reverted? |
|
@jkotas thank you for asking, and thanks to both of you for implementing this so quickly. It does look good at first sight testing with my app. I'm still getting the occasional Segmentation Fault 11 / Abort Trap 6 in some places, but from my early testing, that behavior is unrelated to this change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2166. No longer necessary with local libunwind build.