This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Store the relocation offset delta in the code stream #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
commented
Nov 26, 2016
| { | ||
| fixed (void* location = &blob[i]) | ||
| { | ||
| delta = Relocation.ReadValue(reloc.RelocType, location); |
There was a problem hiding this comment.
This method will need to be completely rewritten for efficiency - I did not spent time on making this fix look pretty.
|
@MichalStrehovsky PTLA |
RyuJIT depends on the relocation offset delta to be stored in the code stream because of it applies additional fixups to it. Tweak the list of Top200 tests to include coverage for this issue. Fixes #2254
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RyuJIT depends on the relocation offset delta to be stored in the code stream because of it applies additional fixups to it.
Tweak the list of Top200 tests to include coverage for this issue.
Fixes #2254