This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Merge nmirror to master #1662
Merged
Merge nmirror to master #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuntimeTypeInfo.GetDeclaredMethods() and GetDeclaredNestedType() were inheriting their implementations from TypeInfo. This is fine with today's bits but as soon as we replace TypeInfo with the one from the full framework, these will break as the full framework TypeInfo routes everything through the BindingFlags apis which won't be implemented yet. To avoid that, we'll override them with a self-sufficient implementation to tide us over until everything's back up and running. This also shone light on the fact that the unspoken convention of making sure each override/no-override decision is made explicit in this particular codebase has bit-rotted some. So I added some new override declarations to fill those holes.
A small preparatory change for TypeInfo restoration.
Addressing a big known problem of the native metadata reader - allocating way too many arrays (and array enumerators) when reading metadata. I'm updating the reader generator to generate XXXCollection types that are structs and have a struct enumerator. I'm specifically not updating the consumers to take advantage of this (i.e. we still sometimes pass the collection as an IEnumerable within the reflection stack). This is because I don't want the changeset to clash with the reflection refactoring work - I would like to push this change into our next release. This makes SharedLibrary.dll 35 kB smaller on x86 because we no longer have the crazy amount of array types implementing all the crazy collection types. [tfs-changeset: 1622617]
Merge changes from TFS
Merge master to nmirror
|
@dotnet-bot test Windows_NT Debug please |
Delete assert to verify asm get current thread implementation because it was not detecting potential bugs soon enough, required extra platform-specific asm code, and there are number of other asserts that will detect potential mismatch between C++ and asm current thread implementation (e.g. in RhpReversePInvokeAttachOrTrapThread2). [tfs-changeset: 1622722]
Merge changes from TFS
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.