This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Implement transition thunk for Unix amd64 #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-bot test this please |
jkotas
changed the title
| @@ -17,8 +17,7 @@ internal unsafe static class CachedInterfaceDispatch | |||
| unsafe private static IntPtr RhpCidResolve(IntPtr callerTransitionBlockParam, IntPtr pCell) | |||
| { | |||
| IntPtr locationOfThisPointer = callerTransitionBlockParam + TransitionBlock.GetThisOffset(); | |||
| IntPtr thisPointerAsIntPtr = *(IntPtr*)locationOfThisPointer; | |||
| object pObject = RuntimeAugments.ConvertIntPtrToObjectReference(thisPointerAsIntPtr); | |||
| object pObject = Unsafe.As<IntPtr, Object>(ref *(IntPtr*)locationOfThisPointer); | |||
There was a problem hiding this comment.
@MichalStrehovsky I cherry picked this from your larger change to cleanup ConvertIntPtrToObjectReference
There was a problem hiding this comment.
I received the necessary signoff from the codegen team and the larger cleanup is now en route to the nmirror branch.
|
Looks reasonable to me, but I never really spent time trying to understand the transition thunk logic in general... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.