This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Merge nmirror to master #1640
Merged
Merge nmirror to master #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API misuse started to hit a new assertion in TryGetMetadataForNamedType that was checking that the type handle passed to it is not garbage (i.e. doesn't refer to a constructed type). I'm moving the check into ExecutionDomain so that it's in the same spot as the other check for blocked types. The added benefit of this is that: * we don't decompose the generic instance type handle twice anymore (the first thing IsReflectionBlocked does with generic types is to fetch the definition) * we don't try to find metadata for something that doesn't have it anyway because it's not a definition [tfs-changeset: 1622087]
Merge changes from TFS
[tfs-changeset: 1622102]
Merge changes from TFS
|
That Unix build break sounds familiar (#1526). I'm on it... |
[tfs-changeset: 1622114]
Merge changes from TFS
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.