Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Revert "Added Range Manipulation APIs to Collection<T> and ObservableCollection<T> (#35772)" #38115

Merged
merged 3 commits into from
May 31, 2019

Conversation

safern
Copy link
Member

@safern safern commented May 31, 2019

Fixes: https://github.com/dotnet/corefx/issues/38085 we decided to revert this change and revisit later to minimize risk for P6 cutoff.

cc: @karelz @danmosemsft @ericstj @stephentoub @vatsan-madhavan @rladuca

@safern safern closed this May 31, 2019
@safern safern reopened this May 31, 2019
@safern
Copy link
Member Author

safern commented May 31, 2019

cc: @wtgodbe we will need to cherry-pick this for P6

@wtgodbe
Copy link
Member

wtgodbe commented May 31, 2019

/azp run corefx-ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wtgodbe
Copy link
Member

wtgodbe commented May 31, 2019

All builds are past the point were APICompat would fail, and the test failures/hangs are known infra issues. merging to unblock code-flow for Preview6.

@wtgodbe wtgodbe merged commit d250626 into dotnet:master May 31, 2019
wtgodbe pushed a commit to dotnet-maestro-bot/corefx that referenced this pull request May 31, 2019
…eCollection<T> (dotnet#35772)" (dotnet#38115)

* Revert "Added Range Manipulation APIs to Collection<T> and ObservableCollection<T> (dotnet#35772)"

This reverts commit b705522.

* Baseline API Compat errors

* Fix baseline vs netstandard
@safern safern deleted the RevertObservableCollectionRange branch May 31, 2019 22:56
@karelz karelz added this to the 3.0 milestone Jul 16, 2019
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
…eCollection<T> (dotnet/corefx#35772)" (dotnet/corefx#38115)

* Revert "Added Range Manipulation APIs to Collection<T> and ObservableCollection<T> (dotnet/corefx#35772)"

This reverts commit dotnet/corefx@b705522.

* Baseline API Compat errors

* Fix baseline vs netstandard


Commit migrated from dotnet/corefx@d250626
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview 6 regression with AddRange on ICollection/Collection
3 participants