This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Make ProcessTests.HandleCountChanges more reliable #37330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krwq
reviewed
May 1, 2019
krwq
reviewed
May 1, 2019
krwq
reviewed
May 1, 2019
krwq
reviewed
May 1, 2019
ViktorHofer
reviewed
May 1, 2019
ViktorHofer
approved these changes
May 1, 2019
|
Thanks a lot for also implementing the retry helper! |
ViktorHofer
approved these changes
May 1, 2019
safern
reviewed
May 1, 2019
ViktorHofer
reviewed
May 1, 2019
src/CoreFx.Private.TestUtilities/src/CoreFx.Private.TestUtilities.csproj
Outdated
Show resolved
Hide resolved
safern
approved these changes
May 1, 2019
|
@stephentoub sorry for causing a conflict. My PR disabled the test with ActiveIssue. Your PR has the right fix for it. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Make ProcessTests.HandleCountChanges more reliable * Address PR feedback * Update CoreFx.Private.TestUtilities.csproj Commit migrated from dotnet/corefx@d398edf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/corefx/issues/37325
cc: @ViktorHofer, @wtgodbe, @krwq