This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Added Range Manipulation APIs to Collection<T> and ObservableCollection<T>#35772

Merged

safern merged 19 commits intodotnet:masterfrom HoeflingSoftware:observablecollection_addrange

May 2, 2019

+995-26

Commits on May 2, 2019

Added Collection<T> AddRange and InsertRange and added new XUnit tests to cover new APIs
Andrew Hoefling
committed
Removed redudent AsSpan parameter in test code
Andrew Hoefling
committed
Removed stale code in test code
Andrew Hoefling
committed
Removed redundent Assert.NotNull calls in several tests
Andrew Hoefling
committed
Added additional check in InsertRange to verify the input collection.Count is greater than 0 before raising the events
Andrew Hoefling
committed
Removed stale code from the NonNullObservableCollection<T> test harness
Andrew Hoefling
committed
Removed unnecessary whitespace
Andrew Hoefling
committed
Renamed new API tests to include the .netcoreapp extension; Updated .Tests.csproj file to only run them when the project is built under .NET core as net standard is the default
Andrew Hoefling
committed
Renamed CollectionTests -> CollectionTests.netcoreapp.cs and only run the test if it is a netcoreapp as the new APIs aren't in netstandard yet
Andrew Hoefling
committed
Added UAP and UAPAOT build configurations for System.ObjectModel tests
Andrew Hoefling
committed
Updated ObservableCollection/Collection tests that use new APIs to be in a partial class with the .netcoreapp.cs extension and existings tests to be in the .cs file.
Andrew Hoefling
committed
Added CollectionTestBase as parent class for CollectionTests for the use case where the other tests are ignored in netstandard builds
Andrew Hoefling
committed
Adding using statements back in which were failing the build
Andrew Hoefling
committed
Moving private classes from the netcoreapp tests to the regular CollectionTests as they were not available in the netstandard CI test run
Andrew Hoefling
committed
Added missing using statement for colleciton tests
Andrew Hoefling
committed
Added if-block that certifies we have replaced items before raising the Replace Event on ReplaceItemsRange
Andrew Hoefling
committed
Removed whitespace in System.Runtime.Tests.csproj
Andrew Hoefling
committed
Added negative test case for ReplaceRange when no items are replaced
Andrew Hoefling
committed
Fixed issue with failing test
Andrew Hoefling
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Range Manipulation APIs to Collection<T> and ObservableCollection<T>#35772

Commits on May 2, 2019

Added Collection<T> AddRange and InsertRange and added new XUnit tests to cover new APIs

Removed redudent AsSpan parameter in test code

Removed stale code in test code

Removed redundent Assert.NotNull calls in several tests

Added additional check in InsertRange to verify the input collection.Count is greater than 0 before raising the events

Removed stale code from the `NonNullObservableCollection<T>` test harness

Removed unnecessary whitespace

Renamed new API tests to include the .netcoreapp extension; Updated .Tests.csproj file to only run them when the project is built under .NET core as net standard is the default

Renamed CollectionTests -> CollectionTests.netcoreapp.cs and only run the test if it is a netcoreapp as the new APIs aren't in netstandard yet

Added UAP and UAPAOT build configurations for System.ObjectModel tests

Updated ObservableCollection/Collection tests that use new APIs to be in a partial class with the .netcoreapp.cs extension and existings tests to be in the .cs file.

Added CollectionTestBase as parent class for CollectionTests for the use case where the other tests are ignored in netstandard builds

Adding using statements back in which were failing the build

Moving private classes from the netcoreapp tests to the regular CollectionTests as they were not available in the netstandard CI test run

Added missing using statement for colleciton tests

Added if-block that certifies we have replaced items before raising the Replace Event on ReplaceItemsRange

Removed whitespace in System.Runtime.Tests.csproj

Added negative test case for ReplaceRange when no items are replaced

Fixed issue with failing test