This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Add documentation which explains how to update reference assembly sources #33515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsonkhan
added
the
documentation
Documentation bug or enhancement, does not impact product or test code
label
Nov 15, 2018
ahsonkhan
requested review from
stephentoub,
danmoseley,
weshaggard and
GrabYourPitchforks
November 15, 2018 02:04
This was referenced Nov 15, 2018
stephentoub
approved these changes
Nov 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Unrelated, intermittent test failures in CI. Ignoring rather than retrying since it's just an md file (not source code change). |
This is awesome! 👍 |
weshaggard
reviewed
Nov 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me.
jlennox
pushed a commit
to jlennox/corefx
that referenced
this pull request
Dec 16, 2018
…rces (dotnet#33515) * Add documentation which explains how to update reference assembly sources * Add example "unique" assemblies that follow System.Runtime steps. * Fix typo/grammar * Add link to System.Memory source csproj
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…rces (dotnet/corefx#33515) * Add documentation which explains how to update reference assembly sources * Add example "unique" assemblies that follow System.Runtime steps. * Fix typo/grammar * Add link to System.Memory source csproj Commit migrated from dotnet/corefx@578b856
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@GrabYourPitchforks requested some documentation: #33395 (comment)