Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Add documentation which explains how to update reference assembly sources #33515

Merged
merged 4 commits into from
Nov 15, 2018

Conversation

ahsonkhan
Copy link

@ahsonkhan ahsonkhan commented Nov 15, 2018

@GrabYourPitchforks requested some documentation: #33395 (comment)

@ahsonkhan ahsonkhan added the documentation Documentation bug or enhancement, does not impact product or test code label Nov 15, 2018
@ahsonkhan ahsonkhan self-assigned this Nov 15, 2018
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@ahsonkhan
Copy link
Author

Unrelated, intermittent test failures in CI. Ignoring rather than retrying since it's just an md file (not source code change).

@ahsonkhan ahsonkhan merged commit 578b856 into dotnet:master Nov 15, 2018
@ahsonkhan ahsonkhan deleted the UpdateRefDoc branch November 15, 2018 04:53
@GrabYourPitchforks
Copy link
Member

This is awesome! 👍

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@karelz karelz added this to the 3.0 milestone Nov 15, 2018
jlennox pushed a commit to jlennox/corefx that referenced this pull request Dec 16, 2018
…rces (dotnet#33515)

* Add documentation which explains how to update reference assembly
sources

* Add example "unique" assemblies that follow System.Runtime steps.

* Fix typo/grammar

* Add link to System.Memory source csproj
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
…rces (dotnet/corefx#33515)

* Add documentation which explains how to update reference assembly
sources

* Add example "unique" assemblies that follow System.Runtime steps.

* Fix typo/grammar

* Add link to System.Memory source csproj


Commit migrated from dotnet/corefx@578b856
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation bug or enhancement, does not impact product or test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants