-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Add missing TypeForwardedFromAttribute to System.Drawing serializable types #33499
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming its complete.
Fine to add but wasn't there discussion about only supporting binary serialization of these drawing types between CoreFX and CoreFX - these attributes are presumably only necessary when .NET Framework did the serialization. Perhaps I misremember. |
I guess that's required for WinForms resource deserialization? |
This might be required for resx, but this is also required for other desktop interop scenarios. |
It's actually the other way around. +1 to resx, it will be required assuming the resgen doesn't change. |
test Linux arm64 Release Build please |
Thanks, @safern. |
… types (dotnet/corefx#33499) Commit migrated from dotnet/corefx@711a104
We missed this attributes when made this types serializable.
FYI: @Tanya-Solyanik