Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Add missing TypeForwardedFromAttribute to System.Drawing serializable types #33499

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

safern
Copy link
Member

@safern safern commented Nov 14, 2018

We missed this attributes when made this types serializable.

FYI: @Tanya-Solyanik

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming its complete.

@danmoseley
Copy link
Member

Fine to add but wasn't there discussion about only supporting binary serialization of these drawing types between CoreFX and CoreFX - these attributes are presumably only necessary when .NET Framework did the serialization. Perhaps I misremember.

@ViktorHofer
Copy link
Member

I guess that's required for WinForms resource deserialization?

@Tanya-Solyanik
Copy link
Member

Tanya-Solyanik commented Nov 14, 2018

This might be required for resx, but this is also required for other desktop interop scenarios.

@ericstj
Copy link
Member

ericstj commented Nov 14, 2018

these attributes are presumably only necessary when .NET Framework did the serialization.

It's actually the other way around. TypeForwardedTo handles the case where netframework did the serialization. TypeForwardedFrom handles the case where netcore does the serialization (and netframework does the de-serialization).

+1 to resx, it will be required assuming the resgen doesn't change.

@safern
Copy link
Member Author

safern commented Nov 15, 2018

test Linux arm64 Release Build please

@stephentoub
Copy link
Member

Thanks, @safern.

@stephentoub stephentoub merged commit 711a104 into dotnet:master Nov 15, 2018
@safern safern deleted the AddTypeForwardedFromDrawing branch November 15, 2018 20:10
@karelz karelz added this to the 3.0 milestone Nov 15, 2018
jlennox pushed a commit to jlennox/corefx that referenced this pull request Dec 16, 2018
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants