This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failures in @dotnet-bot Test Windows x86 Release Build please |
saurabh500
approved these changes
Mar 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much of the code seems to be refactoring to move common code for SqlClient and Odbc into the Common Folder.
Odbc will have fixes like #23722 as well with this change.
saurabh500
reviewed
Mar 19, 2018
|
||
DataTable tableSchema = connection.GetSchema("Tables"); | ||
Assert.NotNull(tableSchema); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Extra line
The test failures are in Http Tests. All other tests passed. The changes dont affect Http |
ericstj
pushed a commit
to ericstj/corefx
that referenced
this pull request
Mar 28, 2018
* Moving DbConnectionInternal to Common * Move the DbConnectionFactory to Common * Implement metadata fetch override * Move DbConnectionPoolGroup to Common * Add the odbc metadata xml to the project * Move the TimeoutTimer to the Common folder * Moving DbReferenceCollection * Moving DbMetadataFactory * Format and convert some properties to expression-bodied syntax * Move the relative path so that VS recognizes the files * Moving the DbConnectionClosed to Common * Adding GetSchemaTests * address code review
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Moving DbConnectionInternal to Common * Move the DbConnectionFactory to Common * Implement metadata fetch override * Move DbConnectionPoolGroup to Common * Add the odbc metadata xml to the project * Move the TimeoutTimer to the Common folder * Moving DbReferenceCollection * Moving DbMetadataFactory * Format and convert some properties to expression-bodied syntax * Move the relative path so that VS recognizes the files * Moving the DbConnectionClosed to Common * Adding GetSchemaTests * address code review Commit migrated from dotnet/corefx@9dc5aad
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull requests primarily enable OdbcConnection.GetSchema() API and its overloads.
The following changes were made to address this
2.a Only moved the files needed to make OdbcConnection.GetSchema() work.
2.b Added partial qualifier on some of the classes which had diverged because SqlClient supports TransactionScope.
Fixes https://github.com/dotnet/corefx/issues/27260
cc @saurabh500