Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Enable OdbcConnection.GetSchema #28175

Merged
merged 13 commits into from
Mar 20, 2018
Merged

Conversation

iamatinkerer
Copy link
Contributor

@iamatinkerer iamatinkerer commented Mar 17, 2018

The pull requests primarily enable OdbcConnection.GetSchema() API and its overloads.

The following changes were made to address this

  1. System.Data.Odbc.OdbcMetaData.xml was added to System.Data.Odbc
  2. Refactored the files in System.Data.Odbc and System.Data.SqlClient and moved them to Common/src/System/Data/ProviderBase
    2.a Only moved the files needed to make OdbcConnection.GetSchema() work.
    2.b Added partial qualifier on some of the classes which had diverged because SqlClient supports TransactionScope.

Fixes https://github.com/dotnet/corefx/issues/27260

cc @saurabh500

@dnfclas
Copy link

dnfclas commented Mar 17, 2018

CLA assistant check
All CLA requirements met.

@saurabh500
Copy link
Contributor

Failures in System.Diagnostics.Process.Tests

@dotnet-bot Test Windows x86 Release Build please
Test Linux x64 Release Build please
Test OSX x64 Debug Build please

Copy link
Contributor

@saurabh500 saurabh500 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much of the code seems to be refactoring to move common code for SqlClient and Odbc into the Common Folder.
Odbc will have fixes like #23722 as well with this change.


DataTable tableSchema = connection.GetSchema("Tables");
Assert.NotNull(tableSchema);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Extra line

@saurabh500 saurabh500 requested a review from keeratsingh March 19, 2018 18:31
@saurabh500
Copy link
Contributor

The test failures are in Http Tests. All other tests passed. The changes dont affect Http

@saurabh500 saurabh500 merged commit 9dc5aad into dotnet:master Mar 20, 2018
@karelz karelz added this to the 2.1.0 milestone Mar 27, 2018
ericstj pushed a commit to ericstj/corefx that referenced this pull request Mar 28, 2018
* Moving DbConnectionInternal to Common

* Move the DbConnectionFactory to Common

* Implement metadata fetch override

* Move DbConnectionPoolGroup to Common

* Add the odbc metadata xml to the project

* Move the TimeoutTimer to the Common folder

* Moving DbReferenceCollection

* Moving DbMetadataFactory

* Format and convert some properties to expression-bodied syntax

* Move the relative path so that VS recognizes the files

* Moving the DbConnectionClosed to Common

* Adding GetSchemaTests

* address code review
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
* Moving DbConnectionInternal to Common

* Move the DbConnectionFactory to Common

* Implement metadata fetch override

* Move DbConnectionPoolGroup to Common

* Add the odbc metadata xml to the project

* Move the TimeoutTimer to the Common folder

* Moving DbReferenceCollection

* Moving DbMetadataFactory

* Format and convert some properties to expression-bodied syntax

* Move the relative path so that VS recognizes the files

* Moving the DbConnectionClosed to Common

* Adding GetSchemaTests

* address code review


Commit migrated from dotnet/corefx@9dc5aad
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants