This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add releasenotes and projecturl in the nuget package. #25316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenlan
reviewed
Nov 17, 2017
| @@ -5,6 +5,8 @@ | |||
| <ProjectReference Include="..\src\Microsoft.XmlSerializer.Generator.csproj" /> | |||
| </ItemGroup> | |||
| <PropertyGroup> | |||
| <ReleaseNotes>https://go.microsoft.com/fwlink/?LinkID=863421</ReleaseNotes> | |||
There was a problem hiding this comment.
Please forward this to dotnet/announcements#39.
zhenlan
approved these changes
Nov 17, 2017
shmao
reviewed
Nov 17, 2017
| @@ -5,6 +5,8 @@ | |||
| <ProjectReference Include="..\src\Microsoft.XmlSerializer.Generator.csproj" /> | |||
| </ItemGroup> | |||
| <PropertyGroup> | |||
| <ReleaseNotes>https://go.microsoft.com/fwlink/?LinkID=863421</ReleaseNotes> | |||
| <projectUrl>https://go.microsoft.com/fwlink/?linkid=858594</projectUrl> | |||
There was a problem hiding this comment.
Should the first p be capital?
There was a problem hiding this comment.
I will update to use capital P. But from https://docs.microsoft.com/en-us/nuget/schema/nuspec, it seems using lower p. Both should work.
shmao
approved these changes
Nov 17, 2017
shmao
pushed a commit
to shmao/corefx
that referenced
this pull request
Dec 6, 2017
* Add releasenotes and projecturl in the nuget package. * Update the description.
shmao
pushed a commit
to shmao/corefx
that referenced
this pull request
Jan 3, 2018
* Add releasenotes and projecturl in the nuget package. * Update the description.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…25316) * Add releasenotes and projecturl in the nuget package. * Update the description. Commit migrated from dotnet/corefx@876fe96
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #25255
@shmao @zhenlan @mconnew