This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix UpdateBlobs regression, reenabling ValueTuple tests on Core, add Dictionary<string,string> serialization test case #24962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
force-pushed
the
ValueTupleUpdateBlobs
branch
from
47b5971 to
fec5755
Compare
|
cc @jkotas this PR contains the test case for Dictionary<string, string>. I also added an explanation why the type forward for NonRandomizedStringEqualityComparer is still needed. |
ViktorHofer
changed the title
jkotas
approved these changes
Oct 31, 2017
|
Requires coreclr change |
|
@dotnet-bot test this please |
ViktorHofer
added a commit
to ViktorHofer/corefx
that referenced
this pull request
Nov 7, 2017
…Dictionary<string,string> serialization test case (dotnet#24962) * Fix UpdateBlobs regression, reenabling ValueTuple tests on Core * Add Dictionary<string,string> serialization test case
ViktorHofer
added a commit
to ViktorHofer/corefx
that referenced
this pull request
Nov 7, 2017
…Dictionary<string,string> serialization test case (dotnet#24962) * Fix UpdateBlobs regression, reenabling ValueTuple tests on Core * Add Dictionary<string,string> serialization test case
ViktorHofer
added a commit
to ViktorHofer/corefx
that referenced
this pull request
Nov 7, 2017
…Dictionary<string,string> serialization test case (dotnet#24962) * Fix UpdateBlobs regression, reenabling ValueTuple tests on Core * Add Dictionary<string,string> serialization test case
ViktorHofer
added a commit
to ViktorHofer/corefx
that referenced
this pull request
Nov 9, 2017
…Dictionary<string,string> serialization test case (dotnet#24962) * Fix UpdateBlobs regression, reenabling ValueTuple tests on Core * Add Dictionary<string,string> serialization test case
ViktorHofer
added a commit
that referenced
this pull request
Nov 15, 2017
…rds (#25047) * Make corefx exceptions serializable and add typeforwards (#24427) * Add serializable attribute and typeforward and adding serialization impl * Expose ZLibException in impl assembly * Remove deserialization negative tests * Adding tests for exceptions * Adding SqlError data to base exception data table * System Data Facade * Add netfx471 blob diffs for Hashtable and ListDictionary * Build Microsoft.NETCore.App.deps.json after manual shims * Disable currently failing uap/uapaot tests because of shim assembly load errors * Cleanup code in System.Runtime.Serialization.Formatters.Tests (#23940) * Cleanup code in System.Runtime.Serialization.Formatters.Tests * Moved UnitySerializationHolder serialization test to System.Runtime.Tests * Fix UpdateBlobs regression, reenabling ValueTuple tests on Core, add Dictionary<string,string> serialization test case (#24962) * Update non NetCoreApp package versions and build them
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…Dictionary<string,string> serialization test case (dotnet/corefx#24962) * Fix UpdateBlobs regression, reenabling ValueTuple tests on Core * Add Dictionary<string,string> serialization test case Commit migrated from dotnet/corefx@b2dcf2c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #24962
The UpdateBlobs method which is manually triggered requires the netfx conditioned test cases to be at the end of the MemberData method. Otherwise it will replace wrong blobs.