ConfigurationManager fix for UAPAOT #20488
Conversation
Use Assembly.CodeBase is not available on uapaot,replacing with Path.Combine(AppDomain.CurrentDomain.BaseDirectory, assemblyName.Name)
|
cc: @JeremyKuhne |
|
@tijoytom per the email thread last week, do I understand right that @MichalStrehovsky will be enabling Assembly.CodeBase to produce something reasonable? Ie., you just don't want to hold up on that. |
| @@ -60,15 +60,17 @@ private ClientConfigPaths(string exePath, bool includeUserConfig) | |||
| // used for local paths and "file://" for UNCs. Simply removing the prefix will make | |||
| // local paths relative on Unix (e.g. "file:///home" will become "home" instead of | |||
| // "/home"). | |||
| Uri uri = new Uri(exeAssembly.CodeBase); | |||
| string configBasePath = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, exeAssembly.GetName().Name); | |||
There was a problem hiding this comment.
You're not using exeAssembly.ManifestModule.Name?
There was a problem hiding this comment.
OK , I will use ManifestModule.Name then
@atsushikan would be the one making that change. After a lengthy email discussion we decided that on Project N, in cases when the original managed assemblies no longer exist because they were fully nativized, |
Assembly.Name
|
restest Innerloop netfx Windows_NT Debug x86 Build and Test |
|
retest Portable Linux x64 Debug Build |
|
Portable Linux x64 Debug Build failure seems to be infrastructure |
|
@JeremyKuhne Is this good for merge? |
|
Sorry, I was OOF. Looks good. |
Use Assembly.CodeBase is not available on
uapaot,replacing with
Path.Combine(AppDomain.CurrentDomain.BaseDirectory,
assembly.ManifestModule.Name)