Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validation suppression from System.Runtime.Serialization.Primitives #16357

Closed
chcosta opened this issue Feb 12, 2016 · 4 comments
Closed

Comments

@chcosta
Copy link
Member

chcosta commented Feb 12, 2016

We're suppressing validation in System.Runtime.Serialization.Primitives until we can oob it to desktop.

@chcosta chcosta self-assigned this Feb 12, 2016
@SGuyGe
Copy link
Contributor

SGuyGe commented Mar 3, 2016

@chcosta What's this about? Is there a main issue that we can reference to?

@chcosta
Copy link
Member Author

chcosta commented Apr 21, 2016

This is a packaging issue. This issue is just tracking that there is cleanup work for us to be done for this library when we can OOB this package to desktop. https://github.com/dotnet/corefx/blob/master/src/System.Runtime.Serialization.Primitives/pkg/ValidationSuppression.txt#L2

@chcosta
Copy link
Member Author

chcosta commented May 9, 2016

@ericstj , can we remove this now?

@ericstj
Copy link
Member

ericstj commented May 9, 2016

Yep, so long as you don't get any validation errors. It looks like the need for this was fixed with dotnet/corefx@5fed590.

chcosta referenced this issue in chcosta/corefx May 16, 2016
…supporession from System.Runtime.Serialization.Prmitives
chcosta referenced this issue in dotnet/corefx May 16, 2016
…supporession from System.Runtime.Serialization.Prmitives (#8572)
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 1.0.0-rtm milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants