This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Expose SerializationInfo.UpdateValue for corefx #6486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| ==============================================================================*/ | ||
| internal void UpdateValue(String name, Object value, Type type) | ||
| public void UpdateValue(String name, Object value, Type type) |
There was a problem hiding this comment.
We should make this under #ifdef FEATURE_CORECLR
There was a problem hiding this comment.
Ok. Both model.xml and mscorlib.cs are specific to CoreCLR already such that there's no ifdef'ing needed there, right?
stephentoub
force-pushed
the
expose_updatevalue
branch
from
dc54465 to
36fdc5d
Compare
ObjectManager in corefx needs to access to SerializationInfo.UpdateValue, which is currently internal. We don't need to expose UpdateValue in a public contract (which would necessitate adding it to desktop), but by making it public we can give corefx the functionality it needs without needing to move a whole bunch more down from corefx into the runtime.
stephentoub
force-pushed
the
expose_updatevalue
branch
from
36fdc5d to
1db5d5a
Compare
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…value Expose SerializationInfo.UpdateValue for corefx Commit migrated from dotnet/coreclr@cfa36dd
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ObjectManager in corefx needs to access to SerializationInfo.UpdateValue, which is currently internal. We don't need to expose UpdateValue in a public contract (which would necessitate adding it to desktop), but by making it public we can give corefx the functionality it needs without needing to move a whole bunch more down from corefx into the runtime.
cc: @jkotas