This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix GetObjectForNativeVariant test issue. #4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-bot
changed the title
…ual object instead of IntPtr. Also add proper variant clean up code. NOTE that I had to keep Marshal.IUnknownForObject call to force COM initialization.
|
The CI seems to be in some what inconsistent state - it enabled running the test but didn't pick up the fix. |
|
@dotnet-bot Test this please |
|
@dotnet-bot Test OSX x64 Checked Build and Test please |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Fix GetObjectForNativeVariant test issue. It should roundtrip the actual object instead of IntPtr. Also add proper variant clean up code. Fix dotnet/coreclr#4192. Commit migrated from dotnet/coreclr@ff26d68
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should roundtrip the actual object instead of IntPtr. Also add proper variant clean up code.
Fix #4192