This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Ported managed Utf8/Unicode encoder/decoder to C++ for usage in PAL #3809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@janvorli I closed the other PR and opened this one because for some reason I couldn't get the CI to run the tests. I believe they should pass now (I was also able to revert the high/low surrogate test to how you originally had it, I believe the error you helped me fix was causing the weird behavior there) |
|
LGTM |
janvorli
added a commit
that referenced
this pull request
Mar 18, 2016
Ported managed Utf8/Unicode encoder/decoder to C++ for usage in PAL
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Ported managed Utf8/Unicode encoder/decoder to C++ for usage in PAL Commit migrated from dotnet/coreclr@6932907
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ported the algorithm from src\mscorlib\src\System\Text\UTF8Encoding.cs to src\pal\src\locale\utf8.cpp, for consistency/performance reasons. Also added a couple of tests. See #1725 for some conversation on this issue.