This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Leftover changes after rebasing my runtime changes against CoreCLR #27751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Viktor moved the empty.csproj script to the repo root, reflect the change; 2) In xplat-pipeline-job, pick coreClrRepoRoot dynamically based on pipeline name (thanks Viktor for the suggestion!); 3) Some fixes to call dotnet through the scripts we recently fixed. 4) Remove superfluous echo in dotnet.cmd per Viktor's feedback. Thanks Tomas
trylek
force-pushed
the
ConsolidationMopUpChanges
branch
2 times, most recently
from
60bcaa4 to
bd8c1df
Compare
to divide the problem space w.r.t. pipeline failure
trylek
force-pushed
the
ConsolidationMopUpChanges
branch
from
bd8c1df to
21e73a7
Compare
janvorli
approved these changes
Nov 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Viktor moved the empty.csproj script to the repo root, reflect
the change;
In xplat-pipeline-job, pick coreClrRepoRoot dynamically based on
pipeline name (thanks Viktor for the suggestion!);
Some fixes to call dotnet through the scripts we recently fixed.
Remove superfluous echo in dotnet.cmd per Viktor's feedback.
Thanks
Tomas