This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Check we don't marshal out parameters in SizeParamIndex test #27439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test passes both uninitialized (null) and initialized values to native. We can add a check to ensure the initialized value doesn't get marshalled to native.
MichalStrehovsky
requested review from
jkoritzinsky
and removed request for
jkoritzinsky
|
Thank you for your contribution. As announced in dotnet/coreclr#27549 this repository will be moving to dotnet/runtime on November 13. If you would like to continue working on this PR after this date, the easiest way to move the change to dotnet/runtime is:
|
|
This doesn't seem to be the right fix for this area. Are you seeing some failure in these tests? /cc @jkoritzinsky |
AaronRobinsonMSFT
approved these changes
Nov 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test passes both uninitialized (null) and initialized values to native.
We can add a check to ensure the initialized value doesn't get marshalled to native.