This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
implement StartsWith and EndsWith as calls to CompareString for sliced string #26481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevingosse
reviewed
Sep 2, 2019
|
|
||
| if (length == 0) return true; | ||
| return Interop.Globalization.StartsWith(_sortHandle, b, length, a, length, options); | ||
| return false; |
There was a problem hiding this comment.
I don't think you can make this assumption in the non-ordinal case.
Thread.CurrentThread.CurrentCulture = CultureInfo.GetCultureInfo("fr-FR");
string str1 = "œ";
string str2 = "oe";
Console.WriteLine(str1.StartsWith(str2, StringComparison.CurrentCulture));
This should print true even though str2.Length > str1.Length
There was a problem hiding this comment.
let's say that this was not my best idea ;p
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.