This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add PAL exports to DAC and remove linkage of PAL from static utility library #23937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmitche
approved these changes
Apr 12, 2019
|
@leecow this PR is ready to merge once shiproom approves |
|
Thanks @janvorli for the suggested fix :) |
|
@tommcdon approved, commit when it completes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #23924, #22861 introduced a dependency in PAL APIs in the util library, which gets transitively linked in the DBI. Replicating Jan's suggested fix, we take the additional APIs needed from the PAL by exporting them on the DAC. The list looks a bit different as there's been some churn in master, which changes the exports needed, but this is a more conservative approach than taking the closure of commits needed for the other commit to be picked into this branch.
I verified this fixes the process attach for OSX and that it causes no issues on Linux-x64 on the customer scenarios that reported it.
cc: @mmitche @tommcdon