Nullable: Internal.Console, System.ValueType #23505
Conversation
|
Same as System.Object.ToString, if we decide it can return null, I think System.ValueType.ToString, do the same thing |
safern
force-pushed
the
NullableFeature
branch
3 times, most recently
from
c01bfd0 to
652234c
Compare
|
@buyaa-n, this PR has a bunch of unrelated commits in it. Can you please rebase to remove them from the PR? It'll then be easier to review. |
Yes, they should match IMO. |
buyaa-n
force-pushed
the
nullable-console-valuetype
branch
from
47662dc to
a11f989
Compare
|
Sure rebased, seems final decision for ToString() not made, will wait for that |
|
@buyaa-n let's make ToString return nullable for now until a final decision is reached to not block ourselves on this, we should make progress: #23510 (comment) |
buyaa-n
force-pushed
the
nullable-console-valuetype
branch
from
a11f989 to
63f6db5
Compare
| @@ -27,7 +28,7 @@ public static unsafe void Write(string s) | |||
| } | |||
| } | |||
|
|
|||
| public static void WriteLine(string s) => | |||
| public static void WriteLine(string? s) => | |||
There was a problem hiding this comment.
It's a little strange that WriteLine(string) accepts null but Write(string) does not. That said, even though this type is "public", it isn't really, so it's not a big deal.
* Nullable: Internal.Console, System.ValueType * Making ToString() nullable Commit migrated from dotnet/coreclr@1f3187e
Very easy PR