-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Intrinsicify SpanHelpers.IndexOfAny(char,char) #22877
Intrinsicify SpanHelpers.IndexOfAny(char,char) #22877
Conversation
Going to wait to review this until after #22816. It looks to be many of the comments are going to be the same overall. |
b0646fa
to
88020cc
Compare
@dotnet-bot test Windows_NT x64 Checked jitx86hwintrinsicnoavx @dotnet-bot test Windows_NT x86 Checked jitx86hwintrinsicnoavx @dotnet-bot test Ubuntu x64 Checked jitx86hwintrinsicnoavx |
Will follow up after #22505 |
88020cc
to
61414d4
Compare
Thank you for your contribution. As announced in dotnet/coreclr#27549 this repository will be moving to dotnet/runtime on November 13. If you would like to continue working on this PR after this date, the easiest way to move the change to dotnet/runtime is:
|
187bf01
to
95a9986
Compare
95a9986
to
9424750
Compare
Rebased ready for review /cc @tannergooding @CarolEidt @GrabYourPitchforks Is there anyway of running CI jobs different intrinsics settings as there was with dotnetbot e.g. #22877 (comment)? /cc @tannergooding @jkotas |
A TODO follow up: is to fold back the last vector rather than going back to sequential for the final unaligned amount; however I'm currently unable to build locally to do performance metrics so with the upcoming repo freeze/merge didn't want to stray too far from what has been previously measured. |
Thank you for your contribution. As announced in #27549 the dotnet/runtime repository will be used going forward for changes to this code base. Closing this PR as no more changes will be accepted into master for this repository. If you’d like to continue working on this change please move it to dotnet/runtime. |
From #22187
Based on #22875 which is first commit
Resolves https://github.com/dotnet/coreclr/issues/22764
/cc @tannergooding @GrabYourPitchforks