-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Clean up register preservation requirements for Enter callback #19560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the detailed addition to CLR-ABI.
src/vm/amd64/asmhelpers.S
Outdated
// - volatile floating point registers (xmm4-5) | ||
// - upper halves of ymm registers on AVX (which are volatile) | ||
// - All argument and callee-saved registers must be preserved: | ||
// RDI, RSI, RDX, RCX, R8, R9, RBX, RBP, R12�R15, XMM0, XMM1, XMM2, XMM3, XMM4, XMM5, XMM6, XMM7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The character between R12 and R15 shows up as garbage when I view this in CodeFlow; I wonder if it's some Unicode thing.
@noahfalk I presume you're still working on this... |
I set it down for a while. Eventually I'll get back to it unless someone wants to beat me to it. The remaining work is testing. |
@noahfalk Just checking... you still expect to get back to it? |
Good call … I had completely forgotten about this : ) I'd still like to get this in but I should probably be more realistic, it may not be me that does it and it may not be soon. Any particular reason you were asking or just checking on status? |
Just checking. I've been looking through lots of old issues/PRs seeing if there's old stuff that can be closed. |
@BruceForstall I can work on this |
Thank you for your contribution. As announced in dotnet/coreclr#27549 this repository will be moving to dotnet/runtime on November 13. If you would like to continue working on this PR after this date, the easiest way to move the change to dotnet/runtime is:
|
Thank you for your contribution. As announced in #27549 the dotnet/runtime repository will be used going forward for changes to this code base. Closing this PR as no more changes will be accepted into master for this repository. If you’d like to continue working on this change please move it to dotnet/runtime. |
#19023
I'm still testing this, so adding NO_MERGE tag even if CI suggests it is good.
@BruceForstall - PTAL
cc @sergign60