This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix recursive inlining of PInvoke stubs #18737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PInvoke stubs can be inlined into a regular methods in CoreRT. PInvoke transition has to be inlined as well when that happens. Otherwise, there is a risk of recursive inlining in corner cases.
|
This should be the last tweak for dotnet/corert#5960 |
|
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test please |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
PInvoke stubs can be inlined into a regular methods in CoreRT. PInvoke transition has to be inlined as well when that happens. Otherwise, there is a risk of recursive inlining in corner cases. Commit migrated from dotnet/coreclr@55023b7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PInvoke stubs can be inlined into a regular methods in CoreRT. PInvoke transition
has to be inlined as well when that happens. Otherwise, there is a risk of recursive
inlining in corner cases.