This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
PInvoke calli support for CoreRT #18534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This limitation seems to be a left-over from effort to eliminate JITing with fragile NGen.
AndyAyersMS
approved these changes
Jun 19, 2018
There was a problem hiding this comment.
Looks good, just one small comment.
You almost certainly know this, but when this change gets mirrored over to desktop it will require some additional changes in desktop files. @sandreenko or I can help with this.
src/jit/inline.def
Outdated
| @@ -107,6 +107,7 @@ INLINE_OBSERVATION(UNSUPPORTED_OPCODE, bool, "unsupported opcode", | |||
| INLINE_OBSERVATION(DEBUG_CODEGEN, bool, "debug codegen", FATAL, CALLER) | |||
| INLINE_OBSERVATION(IS_JIT_NOINLINE, bool, "noinline per JitNoInlineRange", FATAL, CALLER) | |||
| INLINE_OBSERVATION(NEEDS_SECURITY_CHECK, bool, "needs security check", FATAL, CALLER) | |||
| INLINE_OBSERVATION(PINVOKE_EH, bool, "PInvoke from method with EH", FATAL, CALLER) | |||
There was a problem hiding this comment.
NIt: seems like this should be a CALLSITE observation ... ?
|
@dotnet-bot test Windows_NT x64 Checked corefx_baseline |
MichalStrehovsky
approved these changes
Jun 19, 2018
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Ifdef out NGen-specific PInvoke calli inlining limitation for CoreCLR This limitation seems to be a left-over from effort to eliminate JITing with fragile NGen. * Delete dead partial-trust related code * Allow PInvoke stub inlining * Add convertCalliToCall JIT/EE interface method * Update superpmi Commit migrated from dotnet/coreclr@10111af
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CoreCLR, PInvoke calli is implemented via a assembly helper that does a lot of heavy lifting (compares signatures, etc.). This heavy lifting is hard to replicate in CoreRT.
This change introduces an alternative path for calli instruction that is full AOT friendly. When the JIT runs into PInvoke calli, the JIT asks the EE for a regular method to replace it with.
I have also cleaned up a few related things that I have run into along the way (see commit descriptions for details).
Contributes to dotnet/corert#5587