-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Allow ILCodeVersion to fallback to default IL #18502
Allow ILCodeVersion to fallback to default IL #18502
Conversation
For compat with profilers that used our APIs in unexpected ways we can allow the ILCodeVersion to fallback to the default IL code when no IL was explicitly given.
When the debugger is querying the active rejit IL for an IL method that has not been rejitted it incorrectly creates a VMPTR_ILCodeVersionNode for a code version that shouldn't have one.
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test |
@dotnet-bot help |
Welcome to the dotnet/coreclr Perf help The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR The following commands are valid for all PRs and repositories. Click to expand
The following jobs are launched by default for each PR against dotnet/coreclr:release/2.1. Click to expand
The following optional jobs are available in PRs against dotnet/coreclr:release/2.1. Click to expand
Have a nice day! |
Welcome to the dotnet/coreclr Repository The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR The following commands are valid for all PRs and repositories. Click to expand
The following jobs are launched by default for each PR against dotnet/coreclr:release/2.1. Click to expand
The following optional jobs are available in PRs against dotnet/coreclr:release/2.1. Click to expand
Have a nice day! |
Welcome to the dotnet/coreclr Repository The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR The following commands are valid for all PRs and repositories. Click to expand
The following jobs are launched by default for each PR against dotnet/coreclr:release/2.1. Click to expand
The following optional jobs are available in PRs against dotnet/coreclr:release/2.1. Click to expand
Have a nice day! |
For compat with profilers that used our APIs in unexpected ways we can allow
the ILCodeVersion to fallback to the default IL code when no IL was explicitly
given.
This is the 2.1 port for #18448