This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Only use FEATURE_PERFTRACING and FEATURE_EVENT_TRACE features when tu… #17232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rned on Fixes #17199.
|
|
adamsitnik
reviewed
Mar 26, 2018
| @@ -611,7 +611,7 @@ namespace ETW | |||
| #else // FEATURE_EVENT_TRACE | |||
| public: | |||
| static VOID MethodJitting(MethodDesc *pMethodDesc, SString *namespaceOrClassName=NULL, SString *methodName=NULL, SString *methodSignature=NULL) {}; | |||
| static VOID MethodJitted(MethodDesc *pMethodDesc, SString *namespaceOrClassName=NULL, SString *methodName=NULL, SString *methodSignature=NULL, SIZE_T pCode = 0, ReJITID rejitID = 0) {}; | |||
| static VOID MethodJitted(MethodDesc *pMethodDesc, SString *namespaceOrClassName=NULL, SString *methodName=NULL, SString *methodSignature=NULL, SIZE_T pCode = 0, ReJITID rejitID = 0, BOOL bProfilerRejectedPrecompiledCode = FALSE, BOOL bReadyToRunRejectedPrecompiledCode = FALSE) {}; | |||
There was a problem hiding this comment.
@brianrob I don't understand this change. Why do we need to change the signature of MethodJitted?
There was a problem hiding this comment.
This is unrelated to the FEATURE_PERFTRACING. It is related to #15801 which changed the signature of MethodJitted when FEATURE_EVENT_TRACE is defined, but not when it's not.
|
@llamadonica, thanks for contributing this. Can you please sign the CLA and then we can merge this when the CI completes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brianrob @adamsitnik
Allows FEATURE_EVENT_TRACE, FEATURE_PERFTRACING to be turned off.
Fixes #17199.