This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix header inclusion order to avoid use of class before definition #17067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue #17063
In the header rcwrefcache.h, there's a use of RCWCache::RCWCacheTraits, but RCWCache is defined in runtimecallablewrapper.h, which is included later so the class definition is not available. We build CoreCLR as part of regular regression testing for the MSVC compiler, and the build failed recently under the compiler's conformance mode, /permissive-, due to this source issue.
This fixes it by including the RCWRefCache header after the one that provides the RCWCache definition.