-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fix EventSource Test Failures in CoreFX #16999
Conversation
Run EventSource tests: |
Run EventSource tests: |
Does this mean that there's a bug in the EventSource for the System.Net.Security library that had a failed EventSource test as a result of this? |
@dotnet-bot test Ubuntu x64 Checked corefx_baseline |
@stephentoub, the bug is not in NetEventSource, but in the EventPipe support for EventSource. I suspect the issue is that EventPipe doesn't currently know how to serialize arrays, and NetEventSource serializes a byte[]. Prior to the TraceLogging changes I made earlier this week, this would silently fail. What's currently in master does not silently fail. Based on the code in System.Net that I looked at, I expect that the test failure you linked to will be fixed by this PR. |
Run EventSource tests: |
Run was aborted: @dotnet-bot test Ubuntu x64 Checked corefx_baseline |
The failures for Ubuntu x64 Checked Build and Test (Jit - CoreFx) are due to infrastructure issues. I have run this leg manually and confirmed that there are no related failures. |
Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
Signed-off-by: dotnet-bot <[email protected]>
Signed-off-by: dotnet-bot <[email protected]>
Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
Addresses System.Diagnostics.Tracing failures in dotnet/corefx#28112.
Fixes a regression caused by #16861.
This PR addresses two issues: