Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Improve perf of DelegateConstruct #16345

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Improve perf of DelegateConstruct #16345

merged 1 commit into from
Feb 13, 2018

Conversation

AndyAyersMS
Copy link
Member

Remove a range lookup that's no longer needed.

See related issue #12438.

@AndyAyersMS
Improve perf of DelegateConstruct
8313e61 
Remove a range lookup that's no longer needed.

See related issue #12438.
@AndyAyersMS
Copy link
Member Author

@jkotas @janvorli PTAL
cc @briansull @noahfalk (since it impacts music store steady state...)

briansull
briansull approved these changes Feb 12, 2018
View reviewed changes
Copy link

@briansull briansull left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retracted

briansull
briansull suggested changes Feb 12, 2018
View reviewed changes
Copy link

@briansull briansull left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retracted

@AndyAyersMS
Copy link
Member Author

Are you looking at desktop? There is no NeedsSecureDelegate in core.

@briansull
Copy link

Yes I was looking at the desktop/

briansull
briansull approved these changes Feb 12, 2018
View reviewed changes
Copy link

@briansull briansull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good on CoreCLR :-)

jkotas
jkotas approved these changes Feb 13, 2018
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas jkotas merged commit e00d57a into dotnet:master Feb 13, 2018
@AndyAyersMS AndyAyersMS deleted the OptimizeDelegateConstruct branch February 13, 2018 18:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@briansull briansull briansull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndyAyersMS @briansull @jkotas