This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
create GetAssertionIndex to convert from unsigned to AssertionIndex #12554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dotnet/jit-contrib |
sandreenko
force-pushed
the
getAssertionIndex
branch
from
b4d0e88 to
d17452e
Compare
|
@dotnet-bot test FreeBSD x64 Checked Build |
|
@dotnet-bot test Windows_NT x64 Formatting |
|
@dotnet-bot test Windows_NT arm Cross Release Build |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was strange that we increase iterator twice, if you don't know that iter.NextElem(&index)) doesn't use the index value.
This change allows to delete many casts and make code a bit more straightforward.
It is useful part of #11945.