This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Do not pass /O1 except in release/release with debug info modes #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@hadibrais Yeah...I'm going to look into it. |
|
@mmitche You can avoid the stack overflow if you slightly increase the size of the stack reserve for corerun.exe:
It would be nice to have this in, especially the /OPT:ICF part which messes up JIT's GenTree debugging option. |
|
@mikedn I'll try to get to this today. |
mmitche
force-pushed
the
real-debug-build
branch
from
9227e35 to
fd5bea1
Compare
|
@mikedn That worked thanks. |
mmitche
added a commit
that referenced
this pull request
Sep 15, 2015
Do not pass /O1 except in release/release with debug info modes
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Do not pass /O1 except in release/release with debug info modes Commit migrated from dotnet/coreclr@2bc5657
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.