-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StackTrace reports wrong line number for throwing if-statement #13763
Comments
/cc @noahfalk |
mikem8361
referenced
this issue
in mikem8361/diagnostics
Jan 7, 2020
Reported issues https://github.com/dotnet/coreclr/issues/27765 and https://github.com/dotnet/coreclr/issues/25740 for the runtime's unhandled exception message Gracefully fail with runtime module size == 0 Add some more PrintException -lines testing
mikem8361
referenced
this issue
in mikem8361/diagnostics
Jan 8, 2020
Reported issues https://github.com/dotnet/coreclr/issues/27765 and https://github.com/dotnet/coreclr/issues/25740 for the runtime's unhandled exception message Gracefully fail with runtime module size == 0 Add some more PrintException -lines testing
mikem8361
referenced
this issue
in mikem8361/diagnostics
Jan 8, 2020
Reported issues https://github.com/dotnet/coreclr/issues/27765 and https://github.com/dotnet/coreclr/issues/25740 for the runtime's unhandled exception message Gracefully fail with runtime module size == 0 Add some more PrintException -lines testing
mikem8361
referenced
this issue
in mikem8361/diagnostics
Jan 8, 2020
Reported issues https://github.com/dotnet/coreclr/issues/27765 and https://github.com/dotnet/coreclr/issues/25740 for the runtime's unhandled exception message Gracefully fail with runtime module size == 0 Add some more PrintException -lines testing
mikem8361
referenced
this issue
in mikem8361/diagnostics
Jan 8, 2020
The change is to subtract 1 from the IP used to get the source/line info when the stack frame is a leaf node. For hardware exceptions, the IP has already been adjusted (+1) by the runtime so they cancel out. Fixes in SOS the same issues reported in https://github.com/dotnet/coreclr/issues/27765 and https://github.com/dotnet/coreclr/issues/25740 for the runtime's unhandled exception message. Add some more PrintException -lines testing for thrown and hardware exceptions. Gracefully fail with runtime module size == 0.
mikem8361
referenced
this issue
in mikem8361/diagnostics
Jan 10, 2020
The change is to subtract 1 from the IP used to get the source/line info when the stack frame is a leaf node. For hardware exceptions, the IP has already been adjusted (+1) by the runtime so they cancel out. Fixes in SOS the same issues reported in https://github.com/dotnet/coreclr/issues/27765 and https://github.com/dotnet/coreclr/issues/25740 for the runtime's unhandled exception message. Add some more PrintException -lines testing for thrown and hardware exceptions. Gracefully fail with runtime module size == 0.
mikem8361
referenced
this issue
in mikem8361/diagnostics
Jan 11, 2020
The change is to subtract 1 from the IP used to get the source/line info when the stack frame is a leaf node. For hardware exceptions, the IP has already been adjusted (+1) by the runtime so they cancel out. Fixes in SOS the same issues reported in https://github.com/dotnet/coreclr/issues/27765 and https://github.com/dotnet/coreclr/issues/25740 for the runtime's unhandled exception message. Add some more PrintException -lines testing for thrown and hardware exceptions. Gracefully fail with runtime module size == 0. Fix "clrmodules" failure our vendors found.
mikem8361
referenced
this issue
in mikem8361/diagnostics
Jan 11, 2020
The change is to subtract 1 from the IP used to get the source/line info when the stack frame is a leaf node. For hardware exceptions, the IP has already been adjusted (+1) by the runtime so they cancel out. Fixes in SOS the same issues reported in https://github.com/dotnet/coreclr/issues/27765 and https://github.com/dotnet/coreclr/issues/25740 for the runtime's unhandled exception message. Add some more PrintException -lines testing for thrown and hardware exceptions. Gracefully fail with runtime module size == 0. Fix "clrmodules" failure our vendors found.
mikem8361
referenced
this issue
in mikem8361/diagnostics
Jan 14, 2020
The change is to subtract 1 from the IP used to get the source/line info when the stack frame is a leaf node. For hardware exceptions, the IP has already been adjusted (+1) by the runtime so they cancel out. Fixes in SOS the same issues reported in https://github.com/dotnet/coreclr/issues/27765 and https://github.com/dotnet/coreclr/issues/25740 for the runtime's unhandled exception message. Add some more PrintException -lines testing for thrown and hardware exceptions. Gracefully fail with runtime module size == 0. Fix "clrmodules" failure our vendors found.
mikem8361
referenced
this issue
in dotnet/diagnostics
Jan 14, 2020
Fix line number issues in SOS The change is to subtract 1 from the IP used to get the source/line info when the stack frame is a leaf node. For hardware exceptions, the IP has already been adjusted (+1) by the runtime so they cancel out. Fixes in SOS the same issues reported in https://github.com/dotnet/coreclr/issues/27765 and https://github.com/dotnet/coreclr/issues/25740 for the runtime's unhandled exception message. Add some more PrintException -lines testing for thrown and hardware exceptions. Gracefully fail with runtime module size == 0. Fix "clrmodules" failure our vendors found. Add line number (LineNum) check testcase
Fix in PR #2269 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
A similar case has been reported in #13098 for while loops.
The debug output of a thrown exception will report the wrong line in stack-traces.
Repro:
Will report
The text was updated successfully, but these errors were encountered: