Use the ordinal ignore case string comparer for ordering option aliases #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
approved these changes
May 9, 2020
|
Thanks, @kimsey0! |
|
How often are new beta releases pushed to nuget.org? |
|
The process is manual, depending on the impact and stability of recent changes. Every merged PR however produces signed packages that you can get from this feed: https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet5/nuget/v3/index.json |
|
OK. I'd like to use this change and #891 in a project with others who I think would prefer not changing to the nightly build feed. I'll just continue looking forward to this releasing in the nuget.org feed. 🙂 |
|
I'll post an update today then. |
|
Thanks a lot. I appreciate it. |
|
You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #894. I've specified the ordinal ignore case string comparer, since it seems to be the norm in this project to order case insensitively. Let me know if it should actually be
StringComparer.Ordinal.