Fix ArgumentConverted for nullable args #2524
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes cases where conversion of tokens in options of nullable scalar-bindable values with Artities that are not {1,1} like `Option<bool?>` but conversion is still well known.
|
@adamsitnik @jonsequitur - can you please review this? It's something that broke when we bumped diagnostics to more recent versions of commandline. |
mikem8361
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes cases where conversion of tokens in options of nullable scalar-bindable values with Artities that are not {1,1} like
Option<bool?>but conversion is still well known.Alternatively, if this is the only case that's a
ZeroOrOnearity that we care about, it might be faster to elide branches and do what the{1, 1}branch does.